AC-476 Updated PatientDAO for room including six tests#682
Merged
f4ww4z merged 2 commits intoopenmrs:masterfrom Jan 24, 2020
Merged
AC-476 Updated PatientDAO for room including six tests#682f4ww4z merged 2 commits intoopenmrs:masterfrom
f4ww4z merged 2 commits intoopenmrs:masterfrom
Conversation
added tests for PatientRoomDAO Updated PatientDAO for room including six tests
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 12.59% 12.59%
=======================================
Files 232 232
Lines 10643 10643
Branches 991 991
=======================================
Hits 1340 1340
Misses 9222 9222
Partials 81 81
Continue to review full report at Codecov.
|
f4ww4z
requested changes
Jan 24, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@rishabh-997 See my comments below.
| Assert.assertEquals(patientEntities.get(1).getPhoto(),expectedPatientEntity2.getPhoto()); | ||
| Assert.assertEquals(patientEntities.get(1).getPostalCode(),expectedPatientEntity2.getPostalCode()); | ||
| Assert.assertEquals(patientEntities.get(1).getState(),expectedPatientEntity2.getState()); | ||
| Assert.assertEquals(patientEntities.get(1).isSynced(),expectedPatientEntity2.isSynced()); |
Collaborator
There was a problem hiding this comment.
@rishabh-997 It's easier to check the equality of the objects, like:
Assert.assertEquals(patientEntities.get(0), expectedPatientEntity1);
Assert.assertEquals(patientEntities.get(1), expectedPatientEntity2);| Assert.assertEquals(patientEntities.get(0).getPhoto(),expectedPatientEntity2.getPhoto()); | ||
| Assert.assertEquals(patientEntities.get(0).getPostalCode(),expectedPatientEntity2.getPostalCode()); | ||
| Assert.assertEquals(patientEntities.get(0).getState(),expectedPatientEntity2.getState()); | ||
| Assert.assertEquals(patientEntities.get(0).isSynced(),expectedPatientEntity2.isSynced()); |
Collaborator
There was a problem hiding this comment.
Same here. Assert.assertEquals(patientEntities.get(0), expectedPatientEntity2);
| Assert.assertEquals(patientEntities.get(0).getPhoto(),expectedPatientEntity1.getPhoto()); | ||
| Assert.assertEquals(patientEntities.get(0).getPostalCode(),expectedPatientEntity1.getPostalCode()); | ||
| Assert.assertEquals(patientEntities.get(0).getState(),expectedPatientEntity1.getState()); | ||
| Assert.assertEquals(patientEntities.get(0).isSynced(),expectedPatientEntity1.isSynced()); |
| Assert.assertEquals(patientEntities.get(0).getPhoto(),expectedPatientEntity1.getPhoto()); | ||
| Assert.assertEquals(patientEntities.get(0).getPostalCode(),expectedPatientEntity1.getPostalCode()); | ||
| Assert.assertEquals(patientEntities.get(0).getState(),expectedPatientEntity1.getState()); | ||
| Assert.assertEquals(patientEntities.get(0).isSynced(),expectedPatientEntity1.isSynced()); |
|
|
||
| @Override | ||
| public void onSuccess(List<PatientEntity> patientEntities) { | ||
| Assert.assertEquals(patientEntities.size(),1); |
Collaborator
There was a problem hiding this comment.
Suggested change
| Assert.assertEquals(patientEntities.size(),1); | |
| Assert.assertEquals(patientEntities.size(), 1); |
| Assert.assertEquals(patientEntities.size(),1); | ||
|
|
||
| Assert.assertEquals(patientEntities.get(0).getGivenName(),"Rishabh"); | ||
| Assert.assertEquals(patientEntities.get(0).getFamilyName(),"Agarwal"); |
Collaborator
There was a problem hiding this comment.
Needs a space for correct formatting too.
| }); | ||
| } | ||
|
|
||
| private EncounterEntity getEncounterEntity(Long id, String uuid, String display, String visitKeyId, |
Collaborator
There was a problem hiding this comment.
Rename this to newEncounterEntity
| return encounterEntity; | ||
| } | ||
|
|
||
| private PatientEntity getPatientEntity(long id, String uuid, String display, |
Collaborator
There was a problem hiding this comment.
Suggested change
| private PatientEntity getPatientEntity(long id, String uuid, String display, | |
| private PatientEntity newPatientEntity(long id, String uuid, String display, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Updated PatientDAO for room including six tests
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-476
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)