[AC 598] Removed Unused Declarations#656
Merged
f4ww4z merged 3 commits intoopenmrs:masterfrom Jan 4, 2020
Merged
Conversation
prathamesh-mutkure
approved these changes
Jan 3, 2020
Contributor
prathamesh-mutkure
left a comment
prathamesh-mutkure
left a comment
There was a problem hiding this comment.
Everything looks good to me, just make sure to squash all commits into 1 :)
f4ww4z
approved these changes
Jan 4, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
Looks good @rishabh-997 .
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 4, 2020
[AC-533] Add first time intro slides (openmrs#642) [AC 598] Removed Unused Declarations (openmrs#656) squashing commits
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 5, 2020
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 5, 2020
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 7, 2020
[AC-533] Add first time intro slides (openmrs#642) [AC 598] Removed Unused Declarations (openmrs#656) squashing commits
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 8, 2020
created in-app language change added strings in hindi version resolvein changes [AC-533] Add first time intro slides (openmrs#642) [AC 598] Removed Unused Declarations (openmrs#656) squashing commits added hindi translations too requested changes Update strings.xml Update strings.xml added in app hindi adaptability to project
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 9, 2020
created in-app language change added strings in hindi version resolvein changes [AC-533] Add first time intro slides (openmrs#642) [AC 598] Removed Unused Declarations (openmrs#656) squashing commits added hindi translations too requested changes Update strings.xml Update strings.xml added in app hindi adaptability to project added eol to changed files added hindi adaptability to project
rishabh-997
added a commit
to rishabh-997/openmrs-contrib-android-client
that referenced
this pull request
Jan 12, 2020
created in-app language change added strings in hindi version resolvein changes [AC-533] Add first time intro slides (openmrs#642) [AC 598] Removed Unused Declarations (openmrs#656) squashing commits added hindi translations too requested changes Update strings.xml Update strings.xml added in app hindi adaptability to project added eol to changed files added hindi adaptability to project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
There were 30 unused declarations in 21 files, now the project is devoid of unused imports
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-598
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)