Skip to content

[AC-633] Integrate leak canary to debug version#634

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:leakcanary
Dec 20, 2019
Merged

[AC-633] Integrate leak canary to debug version#634
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:leakcanary

Conversation

@rishabh-997
Copy link
Collaborator

Description of what I changed

I added debugImplementation of leak canary in the builld.gradlefile.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-633

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@codecov-io
Copy link

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files         202      202           
  Lines        9222     9222           
  Branches      791      791           
=======================================
  Hits         1329     1329           
  Misses       7812     7812           
  Partials       81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef3380...9a59e96. Read the comment docs.

@rishabh-997 rishabh-997 changed the title integrate leak canary to debug version [AC-633] Integrate leak canary to debug version Dec 15, 2019
@rishabh-997
Copy link
Collaborator Author

@vansha10 @f4ww4z please have a look.

@vansha10
Copy link
Contributor

@rishabh-997 Please go through the Pull Request Guidelines.
Do not start working on issues before they have been marked 'Ready For Work'.

@rishabh-997
Copy link
Collaborator Author

@rishabh-997 Please go through the Pull Request Guidelines.
Do not start working on issues before they have been marked 'Ready For Work'.

I didn't know this, will take care next time...

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rishabh-997 , thanks for the PR. Please follow the PR tips next time, see my comments in the JIRA issue page.

@rishabh-997
Copy link
Collaborator Author

Looks good @rishabh-997 , thanks for the PR. Please follow the PR tips next time, see my comments in the JIRA issue page.

I have claimed the task, you can merge now

@f4ww4z f4ww4z merged commit b3989f0 into openmrs:master Dec 20, 2019
rishabh-997 added a commit to rishabh-997/openmrs-contrib-android-client that referenced this pull request Dec 27, 2019
@rishabh-997 rishabh-997 deleted the leakcanary branch December 28, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants