GCI-340 Android Client: Fix this Static field leak#632
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Dec 5, 2019
RSM55712:master
Merged
GCI-340 Android Client: Fix this Static field leak#632f4ww4z merged 1 commit intoopenmrs:masterfrom RSM55712:master
f4ww4z merged 1 commit intoopenmrs:masterfrom
RSM55712:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 14.29% 14.29%
=======================================
Files 202 202
Lines 9220 9220
Branches 791 791
=======================================
Hits 1318 1318
Misses 7821 7821
Partials 81 81
Continue to review full report at Codecov.
|
suthagar23
approved these changes
Dec 4, 2019
Member
suthagar23
left a comment
suthagar23
left a comment
There was a problem hiding this comment.
Seems good. Let's wait for @f4ww4z approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
In order to bypass the the static memory leak, I created instance variables in each of the other classes that used LinearLayouts and used that to access the methods from the PatientsDashboardActivity class.
Issue I worked on
../../src/main/java/org/openmrs/mobile/activities/patientdashboard/PatientDashboardActivity.java:61: Do not place Android context classes in static fields; this is a memory leak
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).