AC-627: Change ImageView color depending upon theme#620
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Jul 30, 2019
Merged
AC-627: Change ImageView color depending upon theme#620f4ww4z merged 1 commit intoopenmrs:masterfrom
f4ww4z merged 1 commit intoopenmrs:masterfrom
Conversation
Contributor
Author
|
|
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=========================================
- Coverage 14.32% 14.3% -0.02%
=========================================
Files 202 202
Lines 9200 9212 +12
Branches 790 791 +1
=========================================
Hits 1318 1318
- Misses 7801 7813 +12
Partials 81 81
Continue to review full report at Codecov.
|
f4ww4z
requested changes
Jul 22, 2019
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
Thanks @deepak140596 , just address my trivial comments.
| } | ||
|
|
||
| private void changeColorOfImageView() { | ||
| int colorResId = R.color.green; |
Collaborator
There was a problem hiding this comment.
Not a good enough variable name. Also make this a final class variable instead.
Contributor
Author
There was a problem hiding this comment.
@f4ww4z , changed the name to greenColorResId .
openmrs-client/src/main/java/org/openmrs/mobile/activities/dashboard/DashboardFragment.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@f4ww4z , Please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Changed Tint of ImageViews in the Dashboard buttons depending on the theme set.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-627
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)