AC-551: Implement Dark Mode (Experimental) , use CardView instead of custom Card and follow Material guidelines for applying themes.

[deepakpsad]

Description of what I changed

• Added option to switch onto Dark Mode
• Removed unnecessary use of @styles/AppTheme
• Made use of @styles/AppThemeOrig in most of the Activities (it provides default Action Bar)
• Removed unnecessary use of @drawable/card layout as it was incompatible with current material designs
• Removed unnecessary use of setTextColor, setBackgroundColor, setBackgroundTheme, setBackground

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-551

Checklist: I completed these to help reviewers :)

• My pull request only contains ONE single commit
  (the number above, next to the 'Commits' tab is 1).

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

• All new and existing tests passed.

• My pull request is based on the latest changes of the master branch.

[f4ww4z]

@deepak140596 Seems that this PR is not just adding dark mode to the app. Rename the title accordingly.

[f4ww4z]

@deepak140596 What is the change here? Any screenshot of the improved list view?

[deepakpsad]

Thanks @f4ww4z . I am posting the UI. All the rows are now using CardViews with ripple effect for onClick.

[deepakpsad]

One issue still remains, we need to migrate the PNG/JPG icons to vectors. I will create a new issue for that.

[f4ww4z]

One issue still remains, we need to migrate the PNG/JPG icons to vectors. I will create a new issue for that.

Noted, ping me there.

[f4ww4z]

Show us a screenshot of this improved list view.

[codecov-io]

Codecov Report

Merging #618 into master will decrease coverage by <.01%.
The diff coverage is 2.27%.

@@            Coverage Diff            @@
##           master    #618      +/-   ##
=========================================
- Coverage    14.3%   14.3%   -0.01%     
=========================================
  Files         195     196       +1     
  Lines        9093    9104      +11     
  Branches      790     785       -5     
=========================================
+ Hits         1301    1302       +1     
- Misses       7713    7723      +10     
  Partials       79      79

Impacted Files	Coverage Δ
...entrypatientlist/FormEntryPatientListActivity.java	0% <ø> (ø)	⬆️
...le/activities/formdisplay/FormDisplayActivity.java	0% <ø> (ø)	⬆️
...ivities/visitdashboard/VisitDashboardActivity.java	0% <ø> (ø)	⬆️
...ivities/addeditpatient/AddEditPatientActivity.java	0% <ø> (ø)	⬆️
...s/mobile/activities/formlist/FormListActivity.java	0% <ø> (ø)	⬆️
...mobile/activities/dialog/CustomFragmentDialog.java	0% <ø> (ø)	⬆️
...s/mobile/activities/settings/SettingsFragment.java	0% <0%> (ø)	⬆️
...cedpatients/SyncedPatientsRecyclerViewAdapter.java	0% <0%> (ø)	⬆️
...openmrs/mobile/utilities/ApplicationConstants.java	0% <0%> (ø)	⬆️
...mentrypatientlist/FormEntryPatientListAdapter.java	0% <0%> (ø)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d809cd7...b620f6d. Read the comment docs.

[deepakpsad]

These are changed UI and for contrast, both the Day and Night UIs are posted.

[f4ww4z]

@deepak140596 You'll need to implement dark mode in 'Add Patients' screen of 'Find Patients' section. See the screenshot:

Also, try full white (#FFFFFF) for all text color when in dark mode, I think it will look better.

[deepakpsad]

@f4ww4z , I haven't used any hardcoded text color. Android is deciding the text color. We have two options for setting text colors: i) not using any attributes for text color ii) using text color as
android:textColor="?android:attr/textColorPrimary".
The second option will make the text full black (#000000) in Light Mode and full white (#ffffff) in Dark Mode. This needs to be specifically set and should be used in headings.

For body we should just leave it as it is. In the same example we can see there are 2 shades of white.

One exception though, I have used a neutral green color for "Unable to login" option to highlight. Should I replace the color to White?

[f4ww4z]

@deepak140596 Looks good now!

Where does the 'unable to login' view show up?