Skip to content

AC-599: Redundant type cast#609

Merged
f4ww4z merged 4 commits intoopenmrs:masterfrom
Abdelaty:AC-599
Jun 22, 2019
Merged

AC-599: Redundant type cast#609
f4ww4z merged 4 commits intoopenmrs:masterfrom
Abdelaty:AC-599

Conversation

@Abdelaty
Copy link
Contributor

@Abdelaty Abdelaty commented Jun 17, 2019

Signed-off-by: abdelaty abdelaty.mohammedmagdi@gmail.com

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-599

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

Abdelaty added 3 commits June 18, 2019 00:02
Signed-off-by: abdelaty <abdelaty.mohammedmagdi@gmail.com>
Signed-off-by: abdelaty <abdelaty.mohammedmagdi@gmail.com>
# Conflicts:
#	openmrs-client/src/main/java/org/openmrs/mobile/activities/formlist/FormListFragment.java
@codecov-io
Copy link

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files         184      184           
  Lines        8565     8565           
  Branches      746      746           
=======================================
  Hits         1232     1232           
  Misses       7256     7256           
  Partials       77       77
Impacted Files Coverage Δ
...ies/visitdashboard/VisitExpandableListAdapter.java 0% <0%> (ø) ⬆️
...patientdashboard/visits/PatientVisitsFragment.java 0% <0%> (ø) ⬆️
...mobile/activities/dashboard/DashboardActivity.java 0% <0%> (ø) ⬆️
...tientdashboard/details/PatientDetailsFragment.java 0% <0%> (ø) ⬆️
...patientdashboard/details/PatientPhotoActivity.java 0% <0%> (ø) ⬆️
...ivities/visitdashboard/VisitDashboardFragment.java 0% <0%> (ø) ⬆️
...ivities/addeditpatient/AddEditPatientFragment.java 0% <0%> (ø) ⬆️
...rg/openmrs/mobile/application/OpenMRSInflater.java 0% <0%> (ø) ⬆️
...ditpatient/SimilarPatientsRecyclerViewAdapter.java 0% <0%> (ø) ⬆️
...tdashboard/diagnosis/PatientDiagnosisFragment.java 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a94d55...2264eb2. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files         190      190           
  Lines        8738     8738           
  Branches      760      760           
=======================================
  Hits         1270     1270           
  Misses       7389     7389           
  Partials       79       79
Impacted Files Coverage Δ
...ies/visitdashboard/VisitExpandableListAdapter.java 0% <0%> (ø) ⬆️
...patientdashboard/visits/PatientVisitsFragment.java 0% <0%> (ø) ⬆️
...mobile/activities/dashboard/DashboardActivity.java 0% <0%> (ø) ⬆️
...tientdashboard/details/PatientDetailsFragment.java 0% <0%> (ø) ⬆️
...patientdashboard/details/PatientPhotoActivity.java 0% <0%> (ø) ⬆️
...ivities/visitdashboard/VisitDashboardFragment.java 0% <0%> (ø) ⬆️
...ivities/addeditpatient/AddEditPatientFragment.java 0% <0%> (ø) ⬆️
...rg/openmrs/mobile/application/OpenMRSInflater.java 0% <0%> (ø) ⬆️
...ditpatient/SimilarPatientsRecyclerViewAdapter.java 0% <0%> (ø) ⬆️
...tdashboard/diagnosis/PatientDiagnosisFragment.java 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3507f5...7ccf423. Read the comment docs.

@Abdelaty
Copy link
Contributor Author

@f4ww4z Can you review it please

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Abdelaty . Just fix the merge conflict.

@f4ww4z f4ww4z merged commit 501d1a5 into openmrs:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants