Skip to content

Conversation

@ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jun 12, 2025

Signed-off-by: Abner-1 [email protected]

Ⅰ. Describe what this PR does

Carry on with the work on PR #1097

Ⅱ. Does this pull request fix one issue?

fixes #910

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and hellolijj June 12, 2025 08:15
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval by writing /assign @fei-guo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jun 12, 2025
@ABNER-1 ABNER-1 force-pushed the add-inplace-metrics branch 2 times, most recently from b0c8c49 to a687f9e Compare June 12, 2025 11:31
@kruise-bot kruise-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Jun 12, 2025
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

❌ Patch coverage is 67.77778% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.49%. Comparing base (5ca29f3) to head (5773191).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/podadapter/adapter.go 29.62% 16 Missing and 3 partials ⚠️
pkg/controller/daemonset/daemonset_controller.go 0.00% 3 Missing ⚠️
pkg/controller/cloneset/sync/cloneset_update.go 0.00% 2 Missing ⚠️
pkg/util/inplaceupdate/inplace_utils.go 94.44% 2 Missing ⚠️
pkg/util/metrics/update/update_type.go 88.88% 2 Missing ⚠️
pkg/util/inplaceupdate/inplace_update.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
- Coverage   48.54%   48.49%   -0.06%     
==========================================
  Files         324      326       +2     
  Lines       27537    27616      +79     
==========================================
+ Hits        13367    13391      +24     
- Misses      12677    12728      +51     
- Partials     1493     1497       +4     
Flag Coverage Δ
unittests 48.49% <67.77%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ABNER-1 ABNER-1 force-pushed the add-inplace-metrics branch 4 times, most recently from 48a18b5 to 319f97b Compare July 17, 2025 06:02
@ABNER-1 ABNER-1 force-pushed the add-inplace-metrics branch from 319f97b to 39955cc Compare November 13, 2025 03:16
@ABNER-1 ABNER-1 force-pushed the add-inplace-metrics branch from 39955cc to a8b9e43 Compare November 13, 2025 03:55
Signed-off-by: Abner-1 <[email protected]>

Signed-off-by: yuanyuxing.yyx <[email protected]>
@ABNER-1 ABNER-1 force-pushed the add-inplace-metrics branch from a8b9e43 to 5773191 Compare December 11, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL size/XL: 500-999

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] add inPlaceUpdate restart count to annotation

3 participants