docs: Use SPDX license ID #27
Conversation
Maven POM should use SPDX license ID: https://maven.apache.org/pom.html#Licenses SPDX License ID is `GPL-2.0-with-classpath-exception` per https://spdx.org/licenses/GPL-2.0-with-classpath-exception.html Using correct SPDX license ID allows SCA tools (e.g. https://dependencytrack.org/) to correctly identify the used license.
|
Hi @jakub-bochenski, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jakub-bochenski" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
Using full name "GNU General Public License v2.0 w/Classpath exception" as seen in SPDX catalog would also work for my use case |
switch back to ID
This is the license name used by Nashorn: openjdk/nashorn#27 Signed-off-by: jakub-bochenski <[email protected]>
|
Hi, I updated the POM with the full SPDX name of the license. I'll close this PR. |
2 participants
Maven POM should use SPDX license ID: https://maven.apache.org/pom.html#Licenses
SPDX License ID is
GPL-2.0-with-classpath-exceptionper https://spdx.org/licenses/GPL-2.0-with-classpath-exception.htmlThe ID is deprecated, but the replacement is an expression instead of an ID.
Using an expression in place of an ID will result in an invalid CycloneDX BOM, e.g. DependencyTrack/dependency-track#4748
Using correct SPDX license ID allows SCA tools (e.g. https://dependencytrack.org/) to correctly identify the used license.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/nashorn.git pull/27/head:pull/27$ git checkout pull/27Update a local copy of the PR:
$ git checkout pull/27$ git pull https://git.openjdk.org/nashorn.git pull/27/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27View PR using the GUI difftool:
$ git pr show -t 27Using diff file
Download this PR as a diff file:
https://git.openjdk.org/nashorn/pull/27.diff