Skip to content

Conversation

@vpa1977
Copy link

@vpa1977 vpa1977 commented Nov 5, 2025

Configure:

$ sh configure 
... 
checking if date is a GNU compatible version... yes
....

configuration.log

Build:

$ make images 
.... 
Finished building target 'images' in configuration 'linux-x86_64-server-release'

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369450 needs maintainer approval

Issue

  • JDK-8369450: [Ubuntu 25.10] openjdk fails to build due to rust-coreutils date (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4158/head:pull/4158
$ git checkout pull/4158

Update a local copy of the PR:
$ git checkout pull/4158
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4158

View PR using the GUI difftool:
$ git pr show -t 4158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4158.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369450: [Ubuntu 25.10] openjdk fails to build due to rust-coreutils date

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b73228b51c1b1c59c8cd8ee7b14522edc12d564a 8369450: [Ubuntu 25.10] openjdk fails to build due to rust-coreutils date Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 5, 2025
@vpa1977
Copy link
Author

vpa1977 commented Nov 5, 2025

/approval request The fix should be backported in order to be able to build OpenJDK 17 on Ubuntu 25.10 host. The risk estimate is low, as the build will fail otherwise. The backport is clean. I have configured and built the backport branch in Ubuntu 25.10 to validate the fix.

@vpa1977 vpa1977 marked this pull request as ready for review November 5, 2025 09:31
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

⚠️ @vpa1977 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@vpa1977
8369450: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 6, 2025
@vpa1977
Copy link
Author

vpa1977 commented Nov 6, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@vpa1977
Your change (at version 8953da8) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

Going to push as commit 9449e0b.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2025
@openjdk openjdk bot closed this Nov 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@phohensee @vpa1977 Pushed as commit 9449e0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants