Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Nov 2, 2025

This is a backport of JDK-8360406, which is a follow-up to JDK-8341779.


Progress

  • JDK-8360406 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #4151 must be integrated first

Issue

  • JDK-8360406: [21u] Disable logic for attaching type annotations to class files until 8359336 is fixed (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4152/head:pull/4152
$ git checkout pull/4152

Update a local copy of the PR:
$ git checkout pull/4152
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4152

View PR using the GUI difftool:
$ git pr show -t 4152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4152.diff

Using Webrev

Link to Webrev Comment

@cushon cushon marked this pull request as ready for review November 2, 2025 10:01
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4151 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bb83d5935ddc206cd809166c7e71983c62e73f71 8360406: [21u] Disable logic for attaching type annotations to class files until 8359336 is fixed Nov 2, 2025
@openjdk
Copy link

openjdk bot commented Nov 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Nov 2, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant