Fix documentation

[bonjourmauko]

Fixes #243
Fixes #244
Depends on openfisca/openfisca-core#1038

Bug Fix

• Adapt to latest changes in core to render the documentation

Demo:

[MattiSG]

Looks good on my side.

@HAEKADI could you please confirm this fixes the documented problem? 🙂

[HAEKADI]

Thank you @maukoquiroga! Great 👏

This does indeed fix the doc problem, however the Reforms doc is still not generated.

[bonjourmauko]

Thanks a lot for the review @HAEKADI ! In fact, I discovered that half of the doc was still missing 😄 , I've corrected it and it should normally work as expected now.

[HAEKADI]

Yes it does :)
I guess the build will not work before merging the openfisca/openfisca-core#1038.
But otherwise everything seems to be in order 👍

[bonjourmauko]

@HAEKADI exactly, the tricky part of the situation is that as the documentation is in a different repository, we're forced to stage changes somehow to avoid the chicken-egg problems. What I propose in openfisca/openfisca-core#1038 is the easiest way I could imagine to achieve that, without involving complex platform-dependent workflows, obscure git features, and so on. Please do not hesitate if you think of another way to solve the specific core → doc problem to tell me —I did of course thought about re-merging together core and the doc, which is the standard for many libraries, but I intend to propose it separately as it is a major change just for a bug fix IMHO.

[HAEKADI]

@maukoquiroga I agree :) Looking at the changes, it might seem like it is redundant to have them in both repos core and doc. But as you said, as it is a significant task to merge the two, it is better to do it separately.