Make CountryTaxBenefitSystem reusable as a fixture#997
Merged
bonjourmauko merged 22 commits intomasterfrom Apr 14, 2021
Merged
Conversation
Contributor
RamParameswaran
left a comment
There was a problem hiding this comment.
Thanks @maukoquiroga. This is a good forward step towards modularity!
I just have one general question regarding the 'simulation_builder' fixture (see inline comments).
Otherwise, generally looks good - happy to approve 😄
Member
Author
You're right! I've accepted your suggestion. |
Co-authored-by: Ram Parameswaran <33742989+RamParameswaran@users.noreply.github.com>
2465724 to
7311cea
Compare
RamParameswaran
approved these changes
Apr 14, 2021
Contributor
RamParameswaran
left a comment
There was a problem hiding this comment.
LGTM.
I have no additional concerns since my last review. Thanks for incorporating my comment about the simulation_builder fixture.
And the styleguide is fantastic 💥
Nice one @maukoquiroga! 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #969 (it is almost a subset of it, it only extracts CountryTaxBenefitSystem to a fixture).
Related to #984 (it adds more modularity but does not evince country template's scenarios).
Technical changes
CountryTaxBenefitSystemto a fixture reusable by all the tests in the test suite.Performance
Impact on performance of the test suite is neglectable.
Before:
After: