Handle values defined on different period structures#934
Handle values defined on different period structures#934
Conversation
|
This is not the way to go IMO, it makes Holder more complex, when what we want is for them to become simpler… and even simpler, until eventually they go away. Getting rid of Holders is high priority in improving the architecture of Core. Ask yourself - why does this need to be in Holder, where it will be in common use among fine-grained YAML-test-style data and tabular data, when only the former needs it ? Do the Cache API first, migrate to it, get rid of Holders, and then it will be more obvious how to implement this where it should be implemented - in SimulationBuilder. |
|
@Morendil many thanks for your feedback. There are multiple issues to be tacked with such a feature/bug fix
I worked in the first one we'll have to work on the second one as a community. |
|
@guillett : I do understand the need for a feature handling different period range for the same input_variable and I see how it can be useful. I would suggest not to use camel case and use more long names for local variables so it can be more readable by a unexperienced coder as myself and I would definitively give it a second try since this question is important. |
ac70e28 to
8735364
Compare
8735364 to
9672833
Compare
Based on #933
Fixes #564
The new function
solve_input_datais hacky but I would like to start a conversation to have that feature in Core soon.