Skip to content

Update numpy to >=1.11,<1.16#758

Merged
bonjourmauko merged 2 commits intoopenfisca:masterfrom
ServiceInnovationLab:dependabot/pip/numpy-gte-1.11-and-lt-1.16
Nov 10, 2018
Merged

Update numpy to >=1.11,<1.16#758
bonjourmauko merged 2 commits intoopenfisca:masterfrom
ServiceInnovationLab:dependabot/pip/numpy-gte-1.11-and-lt-1.16

Conversation

@Br3nda
Copy link
Copy Markdown
Contributor

@Br3nda Br3nda commented Nov 6, 2018

Technical changes

  • Updates the requirements on numpy to permit the latest version.

@fpagnoux
Copy link
Copy Markdown
Member

fpagnoux commented Nov 6, 2018

There are usually breaking changes coming with new versions of Numpy. Did someone check what they are?
@Morendil, did you try to run France's test with Numpy 1.15?

@Morendil
Copy link
Copy Markdown
Contributor

Morendil commented Nov 6, 2018

Nope, I only eyeballed the release notes; I'll run them right now.

@Morendil
Copy link
Copy Markdown
Contributor

Morendil commented Nov 6, 2018

We're green :)

@fpagnoux
Copy link
Copy Markdown
Member

fpagnoux commented Nov 6, 2018

Great. Looking at the Numpy changelog, I don't see anything that looks like a breaking change in the OpenFisca context.

@bonjourmauko
Copy link
Copy Markdown
Member

This requires a version bump though.

@bonjourmauko bonjourmauko changed the title Update numpy requirement from <1.15,>=1.11 to >=1.11,<1.16 Update numpy to >=1.11,<1.16 Nov 9, 2018
dependabot-support and others added 2 commits November 10, 2018 00:59
Updates the requirements on [numpy](http://www.numpy.org) to permit the latest version.

Signed-off-by: dependabot[bot] <[email protected]>
@bonjourmauko bonjourmauko force-pushed the dependabot/pip/numpy-gte-1.11-and-lt-1.16 branch from b8d5c23 to e571541 Compare November 10, 2018 00:21
@bonjourmauko bonjourmauko merged commit 7914f98 into openfisca:master Nov 10, 2018
@bonjourmauko bonjourmauko added the kind:refactor Refactoring and code cleanup label Nov 13, 2018
@Br3nda Br3nda deleted the dependabot/pip/numpy-gte-1.11-and-lt-1.16 branch January 15, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:refactor Refactoring and code cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants