fix: require fully specifing entities when expanding axes#1202
Merged
bonjourmauko merged 11 commits intomasterfrom Dec 18, 2023
Merged
fix: require fully specifing entities when expanding axes#1202bonjourmauko merged 11 commits intomasterfrom
bonjourmauko merged 11 commits intomasterfrom
Conversation
bonjourmauko
force-pushed
the
fix-default-entities-with-axes
branch
from
d08ecb8 to
6ede041
Compare
bonjourmauko
force-pushed
the
fix-default-entities-with-axes
branch
from
6ede041 to
2491ba1
Compare
Morendil
approved these changes
Dec 13, 2023
Contributor
Morendil
left a comment
Morendil
left a comment
There was a problem hiding this comment.
Other than some quibbles and nitpicks, and the type guards which I don't understand well enough to comment on, but don't look like they affect behaviour, I understand the logic behind theses changes and I believe they effect the intent of the PR as described on Github and in the Changelog.
Closed
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical changes