Merged
Conversation
bonjourmauko
force-pushed
the
fix-doc
branch
from
d265754 to
480e29a
Compare
bonjourmauko
force-pushed
the
fix-doc
branch
from
480e29a to
8fa954e
Compare
bonjourmauko
added
kind:fix
benjello
approved these changes
Nov 29, 2022
Member
|
@maukoquiroga : just to let you know that these changes broke the baremes-ipp generation page and that we fixed it by using python3.9 and importing importlib-metadata. You may consider adding this dep. Do not know if it is an issue or another problem. |
Member
|
If a patch bump forces changing the Python version, this is a big problem and that new version should be yanked asap. |
Member
|
The major problem was importlib_metadata. I bumped the python version to anticipate future deprecations. |
This was referenced Dec 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depended upon by openfisca/openfisca-doc#283
Bug fix