Remove base attribute from ParameterScaleBracket#1162
Conversation
MattiSG
left a comment
There was a problem hiding this comment.
Nice! Less complexity is always good 😄
This will have to be a breaking change.
|
Too late to finally know what it did? I always thought it was some sort of bit wise feature. |
|
@maukoquiroga : some french social security contribution (AGIRC-ARRCO, IRCANTEC, CSG, CRDS) have a theoretical rate and an actual rate with a corrective coefficient. We used base to host the latter to stick to the "law of unique source of truth". But not systematically, resulting in more confusion than convenience. So I prefer to remove it completely to force people follow the rule "explicit is better than implicit". |
537cfeb to
2b1650e
Compare
|
@maukoquiroga : argh test fails after the bump ... |
|
This was failing because of incompatible caches. Now just because its a major, requires #1160 |
d2f0a27 to
8132ab0
Compare
bfd010b to
26c37c0
Compare
Depends on #1160
Breaking changes
This attribute is unclear and was used only for some French social security contributions