Skip to content

Remove base attribute from ParameterScaleBracket#1162

Merged
bonjourmauko merged 2 commits intomasterfrom
remove-taxscale-bracket-base
Dec 1, 2022
Merged

Remove base attribute from ParameterScaleBracket#1162
bonjourmauko merged 2 commits intomasterfrom
remove-taxscale-bracket-base

Conversation

@benjello
Copy link
Copy Markdown
Member

@benjello benjello commented Nov 23, 2022

Depends on #1160

Breaking changes

  • ParameterScaleBracte:
    • Remove base attribute

This attribute is unclear and was used only for some French social security contributions

Copy link
Copy Markdown
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Less complexity is always good 😄

This will have to be a breaking change.

@bonjourmauko
Copy link
Copy Markdown
Member

Too late to finally know what it did? I always thought it was some sort of bit wise feature.

@benjello
Copy link
Copy Markdown
Member Author

benjello commented Nov 23, 2022

@maukoquiroga : some french social security contribution (AGIRC-ARRCO, IRCANTEC, CSG, CRDS) have a theoretical rate and an actual rate with a corrective coefficient. We used base to host the latter to stick to the "law of unique source of truth". But not systematically, resulting in more confusion than convenience. So I prefer to remove it completely to force people follow the rule "explicit is better than implicit".

@benjello benjello force-pushed the remove-taxscale-bracket-base branch from 537cfeb to 2b1650e Compare November 23, 2022 17:03
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 23, 2022

Coverage Status

Coverage increased (+0.05%) to 77.666% when pulling 26c37c0 on remove-taxscale-bracket-base into 0caf9fc on master.

@benjello
Copy link
Copy Markdown
Member Author

@maukoquiroga : argh test fails after the bump ...

@bonjourmauko
Copy link
Copy Markdown
Member

This was failing because of incompatible caches. Now just because its a major, requires #1160

@bonjourmauko bonjourmauko force-pushed the remove-taxscale-bracket-base branch from d2f0a27 to 8132ab0 Compare November 27, 2022 20:11
@bonjourmauko bonjourmauko force-pushed the remove-taxscale-bracket-base branch from bfd010b to 26c37c0 Compare December 1, 2022 16:58
@bonjourmauko bonjourmauko merged commit 27c014f into master Dec 1, 2022
@bonjourmauko bonjourmauko deleted the remove-taxscale-bracket-base branch December 1, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants