Skip to content

Add type hints to some variables#1151

Merged
bonjourmauko merged 6 commits intoopenfisca:masterfrom
nikhilwoodruff:type-hints
Nov 21, 2022
Merged

Add type hints to some variables#1151
bonjourmauko merged 6 commits intoopenfisca:masterfrom
nikhilwoodruff:type-hints

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Contributor

This helps IDEs like VS Code recognise and suggest class properties.

New features

  • Add type hints for all instances of variable_name in function declarations.
  • Add type hints for some Simulation and Population properties.

@nikhilwoodruff
Copy link
Copy Markdown
Contributor Author

Hmm, there's a lot of unexpected issues here.

@MattiSG
Copy link
Copy Markdown
Member

MattiSG commented Sep 9, 2022

Indeed! I suggest you focus on the results of make lint, which you can run locally for faster feedback 🙂

@bonjourmauko bonjourmauko requested a review from a team November 21, 2022 08:30
@bonjourmauko
Copy link
Copy Markdown
Member

Weirdly the status checks do not seem to run on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants