Skip to content

Fix pristine editable install#1137

Merged
bonjourmauko merged 4 commits intomasterfrom
fix-pristine-editable-install
Jul 30, 2022
Merged

Fix pristine editable install#1137
bonjourmauko merged 4 commits intomasterfrom
fix-pristine-editable-install

Conversation

@bonjourmauko
Copy link
Copy Markdown
Member

@bonjourmauko bonjourmauko commented Jul 28, 2022

Fixes #1136

Technical changes

  • Fix pylint dependency in fresh editable installations
    • Ignore pytest requirement, used to collect test cases, if it is not yet installed.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.94% when pulling a2b4dd5 on fix-pristine-editable-install into 3eb157f on master.

@bonjourmauko bonjourmauko requested review from a team July 28, 2022 16:32
Copy link
Copy Markdown
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!
Could you please give an example to reproduce the error you encountered and intend to fix with this changeset? 🙂 I don't understand how it is possible to run make test-core without pytest installed, yet openfisca installed.

@MattiSG
Copy link
Copy Markdown
Member

MattiSG commented Jul 29, 2022

Sorry, I just saw the link to #1136 🤦 Trying to reproduce now 🙂

Copy link
Copy Markdown
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I could reproduce the issue described in #1136.
  • Maintaining make install on top of the installation procedure described in the README is consistent with #1040.
  • I checked flake8 v4 changelog, and I believe the breaking changes are not impactful for reusers.

While I believe silencing errors has potential side effects (see #1138 (comment)) and is not optimal (I would prefer that we stop test-core from being called when make install is called!), I can approve the current changeset.

@bonjourmauko
Copy link
Copy Markdown
Member Author

Thanks @MattiSG , I agree and actually find make increasingly painful to maintain as a tool. I hope we converge sooner than later to a more democratic and sustainable task manager for OpenFisca.

@bonjourmauko bonjourmauko merged commit e18f23b into master Jul 30, 2022
@bonjourmauko bonjourmauko deleted the fix-pristine-editable-install branch July 30, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pristine editable install with make throws pytest error

3 participants