Drop latest NumPy supported version to 1.18#1014
Conversation
sandcha
left a comment
There was a problem hiding this comment.
Compared to #990 content and all seems to be reverted.
I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analyzed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).
|
Thanks a lot @sandcha !
Again thanks a lot for your proactiveness to try to find a way to unblock users 😃 There are a couple of factors that convinced me to propose this way of dealing with the issue, and here instead of Slack:
This issue is rather easy because of 1. supra —I cheated! 🤣— but others won't be so. |
Fixes #1009
Supersedes #1012
Depended on by #1010
Bug fix
__future__.annotations, those stubs or type sheds are casted totyping.Anytyping.TYPE_CHEKINGvariablenumpy.typingmodule was being imported at runtime, rendering OpenFisca unusable to all users depending on previous versions of NumPy (1.20.x-)