-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: created api to get course modes in instructor app #37594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
69a052f to
30d0d7e
Compare
| def _cohorts_csv_validator(file_storage, file_to_validate): | ||
| """ | ||
| Verifies that the expected columns are present in the CSV used to add users to cohorts. | ||
| Verifies that the expected columns are present in the CSV` used to add users to cohorts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
| Response: A DRF Response object containing the serialized | ||
| course modes or an error. | ||
| """ | ||
| if not CourseOverview.objects.filter(id=course_id).exists(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a redundant check, if course doesn't exist we will get 404 in permission check. we can safely skip this.
fix: resolved linter errors chore: added docs to api fix: removed redundant code fix: removed redundant code
34201ee to
6d0bf82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new API endpoint to retrieve course enrollment modes (e.g., audit, verified) for instructors and staff, along with comprehensive test coverage.
- Adds
CourseModeListViewAPI endpoint for fetching enrollment modes - Creates
CourseModeSerializerandCourseModeListSerializerfor API responses - Implements authentication/authorization checks and comprehensive tests
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| lms/djangoapps/instructor/views/serializer.py | Adds CourseModeSerializer and CourseModeListSerializer to serialize course mode data |
| lms/djangoapps/instructor/views/api_urls.py | Registers the new course_modes_list endpoint in the v1 API URL patterns |
| lms/djangoapps/instructor/views/api.py | Implements CourseModeListView class with GET handler and documentation |
| lms/djangoapps/instructor/tests/test_api.py | Adds comprehensive test suite covering authentication, permissions, and response validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Thanks for the pull request, @AhtishamShahid! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Issue : #37465
This PR added API endpoint to get course modes for instructor dashboard .
/api/instructor/v1/courses/{course_key}/modes