Skip to content

Update deployment.yaml #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminmaghsodi wants to merge 1 commit into from
Closed

Update deployment.yaml #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/helm/charts/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ kind: Deployment
metadata:
name: {{ template "localpv.fullname" . }}
{{- with .Values.localpv.annotations }}
namespace: {{ .Release.Namespace }}
Copy link
Member

@tiagolobocastro tiagolobocastro Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just default? From your description thought you'd want to pass some other var for the namespace

Copy link
Member

@tiagolobocastro tiagolobocastro Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it now, for the helm template... could you please also add it to the service account?

Copy link
Member

@tiagolobocastro tiagolobocastro Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminmaghsodi a gentle ping :)

annotations: {{ toYaml . | nindent 4 }}
{{- end }}
labels:
Expand Down