This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Refactorpolicyid #357
Merged
bowenlan-amzn
merged 3 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:refactorpolicyid
Feb 1, 2021
Merged
Refactorpolicyid #357
bowenlan-amzn
merged 3 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:refactorpolicyid
Feb 1, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
============================================
+ Coverage 77.23% 77.54% +0.31%
Complexity 1511 1511
============================================
Files 197 196 -1
Lines 7748 7784 +36
Branches 1250 1244 -6
============================================
+ Hits 5984 6036 +52
+ Misses 1083 1071 -12
+ Partials 681 677 -4
Continue to review full report at Codecov.
|
qreshi
reviewed
Jan 29, 2021
.../indexmanagement/indexstatemanagement/transport/action/addpolicy/TransportAddPolicyAction.kt
Outdated
Show resolved
Hide resolved
...asticsearch/indexmanagement/indexstatemanagement/transport/action/explain/ExplainResponse.kt
Outdated
Show resolved
Hide resolved
...oforelasticsearch/indexmanagement/indexstatemanagement/resthandler/RestChangePolicyAction.kt
Outdated
Show resolved
Hide resolved
...n/com/amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/Policy.kt
Outdated
Show resolved
Hide resolved
...relasticsearch/indexmanagement/indexstatemanagement/coordinator/ManagedIndexCoordinatorIT.kt
Show resolved
Hide resolved
qreshi
reviewed
Jan 29, 2021
...relasticsearch/indexmanagement/indexstatemanagement/coordinator/ManagedIndexCoordinatorIT.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 29, 2021
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexmanagement/IndexManagementIndices.kt
Outdated
Show resolved
Hide resolved
qreshi
reviewed
Jan 29, 2021
...relasticsearch/indexmanagement/indexstatemanagement/coordinator/ManagedIndexCoordinatorIT.kt
Show resolved
Hide resolved
...management/indexstatemanagement/transport/action/removepolicy/TransportRemovePolicyAction.kt
Outdated
Show resolved
Hide resolved
...management/indexstatemanagement/transport/action/removepolicy/TransportRemovePolicyAction.kt
Show resolved
Hide resolved
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 29, 2021
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 30, 2021
...n/opendistroforelasticsearch/indexmanagement/indexstatemanagement/ManagedIndexCoordinator.kt
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 30, 2021
...ndistroforelasticsearch/indexmanagement/indexstatemanagement/elasticapi/ElasticExtensions.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 30, 2021
...distroforelasticsearch/indexmanagement/indexstatemanagement/settings/ManagedIndexSettings.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 30, 2021
| private val request: AddPolicyRequest | ||
| ) { | ||
| private lateinit var startTime: Instant | ||
| private val indicesToAdd = mutableMapOf<String, String>() // uuid: name |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take advantage of typealiases for this stuff since it's confusing just seeing string :P
But, can do that in later PR
dbbaughe
reviewed
Feb 1, 2021
.../indexmanagement/indexstatemanagement/transport/action/addpolicy/TransportAddPolicyAction.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Feb 1, 2021
.../indexmanagement/indexstatemanagement/transport/action/addpolicy/TransportAddPolicyAction.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Feb 1, 2021
.../indexmanagement/indexstatemanagement/transport/action/addpolicy/TransportAddPolicyAction.kt
Outdated
Show resolved
Hide resolved
dbbaughe
approved these changes
Feb 1, 2021
qreshi
approved these changes
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking change
A change in one part of a software system that causes other parts to fail, require user change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR aims to remove policyID usage in ISM
Previously policyID is used like a proxy for applying and removing policy to index, now we apply/remove policy by creating/deleting job document directly.
This PR is based on
get all and explain allPRssince explain API is related to policyID
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.