Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@dbbaughe
Copy link
Contributor

Issue #, if available:

Description of changes:
Integ tests will be included with the runner PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #339 (0215f9c) into master (469a646) will decrease coverage by 1.46%.
The diff coverage is 21.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #339      +/-   ##
============================================
- Coverage     72.80%   71.33%   -1.47%     
- Complexity     1187     1195       +8     
============================================
  Files           181      181              
  Lines          6078     6249     +171     
  Branches        921      954      +33     
============================================
+ Hits           4425     4458      +33     
- Misses         1188     1316     +128     
- Partials        465      475      +10     
Impacted Files Coverage Δ Complexity Δ
...csearch/indexmanagement/rollup/util/RollupUtils.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sticsearch/indexmanagement/rollup/RollupIndexer.kt 8.47% <5.26%> (-91.53%) 1.00 <0.00> (ø)
...arch/indexmanagement/rollup/RollupMapperService.kt 30.63% <29.90%> (-19.37%) 9.00 <8.00> (+8.00) ⬇️
...icsearch/indexmanagement/IndexManagementIndices.kt 63.33% <100.00%> (-2.19%) 10.00 <0.00> (ø)
...nt/indexstatemanagement/model/destination/Slack.kt 40.90% <0.00%> (-13.64%) 2.00% <0.00%> (-2.00%)
...adata/TransportUpdateManagedIndexMetaDataAction.kt 85.18% <0.00%> (-3.71%) 9.00% <0.00%> (-1.00%)
...ch/indexmanagement/elasticapi/ElasticExtensions.kt 62.22% <0.00%> (-2.23%) 0.00% <0.00%> (ø%)
...agement/indexstatemanagement/ManagedIndexRunner.kt 55.04% <0.00%> (-0.62%) 41.00% <0.00%> (ø%)
...asticsearch/indexmanagement/rollup/model/Rollup.kt 82.47% <0.00%> (+1.03%) 43.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a9294...0215f9c. Read the comment docs.

// where they can both get the same mapping state and only add their own job, meaning one
// of the jobs won't be added to the target index _meta
@Suppress("BlockingMethodInNonBlockingContext", "ReturnCount")
private suspend fun updateRollupIndexMappings(rollup: Rollup): RollupJobValidationResult {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional - TODO: disable and not update job in target index if it clashes with other existing jobs, e.g. if the job1 is using fieldA as metric then job2 cannot use fieldA as dimension.

@dbbaughe dbbaughe merged commit 7764bae into opendistro-for-elasticsearch:master Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants