Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Jun 24, 2020

Issue #, if available:
#142

Description of changes:

possible use case

Sets the priority of the index as soon as the policy enters certain state. Unallocated shards of indices are recovered in order of priority, whenever possible.
reference from ES

"actions": [
    {
        "index_priority": {
            "priority": 50
        }
    }
]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bowenlan-amzn bowenlan-amzn requested review from dbbaughe and qreshi June 24, 2020 17:44
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #241 into master will increase coverage by 0.42%.
The diff coverage is 78.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     70.84%   71.27%   +0.42%     
- Complexity      613      625      +12     
============================================
  Files            83       86       +3     
  Lines          3584     3648      +64     
  Branches        593      601       +8     
============================================
+ Hits           2539     2600      +61     
+ Misses          742      737       -5     
- Partials        303      311       +8     
Impacted Files Coverage Δ Complexity Δ
.../indexstatemanagement/model/action/ActionConfig.kt 93.75% <66.66%> (+0.27%) 8.00 <0.00> (ø)
...nagement/model/action/IndexPriorityActionConfig.kt 69.56% <69.56%> (ø) 4.00 <4.00> (?)
...indexstatemanagement/action/IndexPriorityAction.kt 83.33% <83.33%> (ø) 2.00 <2.00> (?)
.../step/indexpriority/AttemptSetIndexPriorityStep.kt 84.84% <84.84%> (ø) 4.00 <4.00> (?)
...ticsearch/indexstatemanagement/model/Transition.kt 80.39% <0.00%> (ø) 5.00% <0.00%> (ø%)
...exstatemanagement/model/destination/Destination.kt 47.05% <0.00%> (+1.47%) 6.00% <0.00%> (+1.00%)
...ch/indexstatemanagement/model/destination/Chime.kt 57.14% <0.00%> (+42.85%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ab545...f931b0f. Read the comment docs.

@bowenlan-amzn bowenlan-amzn requested a review from dbbaughe June 25, 2020 19:51
@bowenlan-amzn
Copy link
Contributor Author

already checked this has no conflict with opendistro-1.9 update, safe to merge in

}
}

private fun getClient(adminClient: AdminClient): Client = mock { on { admin() } doReturn adminClient }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: Missing newlines in between function definitions

@bowenlan-amzn bowenlan-amzn added action Index management actions enhancement An improvement on the existing feature’s functionalities labels Jun 25, 2020
@bowenlan-amzn bowenlan-amzn merged commit c011253 into opendistro-for-elasticsearch:master Jun 25, 2020
@bowenlan-amzn bowenlan-amzn deleted the priority-action branch June 25, 2020 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action Index management actions enhancement An improvement on the existing feature’s functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants