This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Add an Action to Setting Index Priority #241
Merged
bowenlan-amzn
merged 6 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:priority-action
Jun 25, 2020
Merged
Add an Action to Setting Index Priority #241
bowenlan-amzn
merged 6 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:priority-action
Jun 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
============================================
+ Coverage 70.84% 71.27% +0.42%
- Complexity 613 625 +12
============================================
Files 83 86 +3
Lines 3584 3648 +64
Branches 593 601 +8
============================================
+ Hits 2539 2600 +61
+ Misses 742 737 -5
- Partials 303 311 +8
Continue to review full report at Codecov.
|
dbbaughe
reviewed
Jun 25, 2020
...tlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/model/action/ActionConfig.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/TestHelpers.kt
Outdated
Show resolved
Hide resolved
...istroforelasticsearch/indexstatemanagement/step/indexpriority/AttemptSetIndexPriorityStep.kt
Outdated
Show resolved
Hide resolved
...istroforelasticsearch/indexstatemanagement/step/indexpriority/AttemptSetIndexPriorityStep.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jun 25, 2020
Contributor
Author
|
already checked this has no conflict with opendistro-1.9 update, safe to merge in |
dbbaughe
approved these changes
Jun 25, 2020
qreshi
reviewed
Jun 25, 2020
| } | ||
| } | ||
|
|
||
| private fun getClient(adminClient: AdminClient): Client = mock { on { admin() } doReturn adminClient } |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP: Missing newlines in between function definitions
qreshi
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action
Index management actions
enhancement
An improvement on the existing feature’s functionalities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#142
Description of changes:
possible use case
Sets the priority of the index as soon as the policy enters certain state. Unallocated shards of indices are recovered in order of priority, whenever possible.
reference from ES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.