Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@dtrifiro
Copy link

@dtrifiro dtrifiro commented May 21, 2024

Building a more recent version of the vllm code with fixed .so from specific releases might end up breaking features if the python code contains references to features that aren't present in the downloaded wheel.

Also add the CMAKE_BUILD_TYPE=Release in order to build stripped and optimized wheels.

@openshift-ci openshift-ci bot requested review from Xaenalt and heyselbi May 21, 2024 13:03
@dtrifiro dtrifiro requested a review from z103cb May 21, 2024 13:04
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Building a more recent version of the vllm code with fixed `.so`
from specific releases might end up breaking features if the python
code contains references to features that aren't present in the
downloaded wheel.
@dtrifiro dtrifiro force-pushed the dockerfile-build-extensions branch from 86905cf to a99d732 Compare May 21, 2024 13:15
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@z103cb
Copy link

z103cb commented May 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8103d10 into opendatahub-io:ibm_main May 21, 2024
@dtrifiro dtrifiro deleted the dockerfile-build-extensions branch May 22, 2024 12:12
openshift-merge-bot bot pushed a commit that referenced this pull request May 22, 2024
This PR logs all errors during validation or generation
for a request like TGIS does. 

Signed-off-by: Joe Runde <[email protected]>
Xaenalt pushed a commit that referenced this pull request Sep 18, 2024
WA: Disable cumsum in HPU _prepare_prompt
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants