This repository was archived by the owner on Sep 4, 2025. It is now read-only.
forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 13
Dockerfile.ubi: get rid of prebuilt-wheel stage #30
Merged
openshift-merge-bot
merged 2 commits into
opendatahub-io:ibm_main
from
dtrifiro:dockerfile-build-extensions
May 21, 2024
Merged
Dockerfile.ubi: get rid of prebuilt-wheel stage #30
openshift-merge-bot
merged 2 commits into
opendatahub-io:ibm_main
from
dtrifiro:dockerfile-build-extensions
May 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
approved these changes
May 21, 2024
z103cb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Building a more recent version of the vllm code with fixed `.so` from specific releases might end up breaking features if the python code contains references to features that aren't present in the downloaded wheel.
86905cf to
a99d732
Compare
z103cb
approved these changes
May 21, 2024
z103cb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, z103cb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
May 22, 2024
This PR logs all errors during validation or generation for a request like TGIS does. Signed-off-by: Joe Runde <[email protected]>
Xaenalt
pushed a commit
that referenced
this pull request
Sep 18, 2024
WA: Disable cumsum in HPU _prepare_prompt
prarit
pushed a commit
to prarit/vllm
that referenced
this pull request
Oct 18, 2024
fix the model loading fp8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a more recent version of the vllm code with fixed
.sofrom specific releases might end up breaking features if the python code contains references to features that aren't present in the downloaded wheel.Also add the
CMAKE_BUILD_TYPE=Releasein order to build stripped and optimized wheels.