Skip to content

Conversation

@njhill
Copy link
Contributor

@njhill njhill commented Jul 29, 2024

This reverts commit 0f7df61.

This should be merged once we're including vllm-project/vllm#6698 in the corresponding vllm. That one should be merged to upstream imminently.

@njhill njhill requested a review from dtrifiro July 29, 2024 22:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (09290e6) to head (ee33319).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   61.29%   61.36%   +0.07%     
==========================================
  Files          20       20              
  Lines        1186     1183       -3     
  Branches      210      209       -1     
==========================================
- Hits          727      726       -1     
+ Misses        383      382       -1     
+ Partials       76       75       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njhill njhill marked this pull request as ready for review August 7, 2024 18:32
@dtrifiro dtrifiro enabled auto-merge August 8, 2024 09:57
@dtrifiro dtrifiro added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 96b8e0f Aug 8, 2024
@dtrifiro dtrifiro deleted the enable-pp-seed branch August 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants