Skip to content

Conversation

@Jooho
Copy link

@Jooho Jooho commented Apr 24, 2023

Motivation

Opendatahub manifests structure is different from upstream manifests. For this reason, it was difficult to synchronize upstream sources to ODH repos. Moreover, fvt test was not working with opendatahub manifests.
The change will help

  • to check if upstream manifests is the same as opendatahub manifests.
  • to generate a new manifests based on upstream manifests
  • to deploy some required components for FVT test with opendatahub manifests.

Modifications

It includes

  • opendatahub folders
    • scripts
    • scripts/manifessts
    • odh-manifests
  • Makefile update

How to test?

  1. Generate a new manifests and check if it is the same as the previous one
./opendatahub/scripts/gen_odh_modelmesh_manifests.sh
Generate opendatahub manifest in the /tmp/modelmesh-20230424041682356897
TARGET DIR: /tmp/modelmesh-20230424041682356897
--------------------------------------------------

 ✓ Creating a /tmp/modelmesh-20230424041682356897 folder
 ✓ Copying the model-mesh_templates to /tmp/modelmesh-20230424041682356897 folder
 ✓ Git Cloning odh-modelmesh-controller to /tmp/modelmesh-20230424041682356897 folder
 ✓ Copying the odh-modelmesh-controller manifests to model-mesh_templates folder
 ✓ Comment out ClusterServingRuntime
 ✓ Remove builtInServerTypes
 ✓ Add parameter variable into modelmesh-controller-rolebinding
 ✓ Replace each image of the parameter variable 'images'
 ✓ Replace replicas of odh modelmesh controller to 3
New Manifests are identical with previous one. You don't need to send any PR to ODH-MANIFESTS repo
  1. Deploy opendatahub manifest
    Refer ./opendatahub/docs/manifests-management.md
    This doc explains how to deploy and how to test.

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

==> This is odh-manifest changes so it does not impact these tests.

Issue:

@openshift-ci openshift-ci bot requested review from Xaenalt and heyselbi April 24, 2023 17:37
@Jooho Jooho changed the title Restructed odh manifests restructured odh manifests Apr 24, 2023
@Jooho Jooho force-pushed the restructed_odh_manifests branch from 508f69d to 55bba6d Compare April 25, 2023 14:27
@Jooho Jooho force-pushed the restructed_odh_manifests branch from 693dccb to 2477bb2 Compare April 26, 2023 02:21
Signed-off-by: jooho <[email protected]>
@Jooho Jooho force-pushed the restructed_odh_manifests branch 10 times, most recently from 7ef31f5 to 90fba39 Compare April 28, 2023 15:13
@Jooho Jooho force-pushed the restructed_odh_manifests branch 16 times, most recently from 2c07836 to 912f91c Compare April 29, 2023 18:45
@Jooho
Copy link
Author

Jooho commented Apr 29, 2023

/retest

1 similar comment
@Jooho
Copy link
Author

Jooho commented Apr 29, 2023

/retest

@Jooho Jooho force-pushed the restructed_odh_manifests branch 3 times, most recently from dd647ce to 5fd5054 Compare April 30, 2023 23:46
@Jooho Jooho force-pushed the restructed_odh_manifests branch from 5fd5054 to 529b51f Compare May 1, 2023 01:54
@openshift-ci
Copy link

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a3f60c into opendatahub-io:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants