forked from kserve/modelmesh-serving
-
Notifications
You must be signed in to change notification settings - Fork 42
restructured odh manifests #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 13 commits into
opendatahub-io:main
from
Jooho:restructed_odh_manifests
May 1, 2023
Merged
restructured odh manifests #90
openshift-merge-robot
merged 13 commits into
opendatahub-io:main
from
Jooho:restructed_odh_manifests
May 1, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include reviewers as approvers too Signed-off-by: Sean Pryor <[email protected]>
Signed-off-by: Selbi <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: jooho <[email protected]>
Signed-off-by: jooho <[email protected]>
508f69d to
55bba6d
Compare
Signed-off-by: jooho <[email protected]>
693dccb to
2477bb2
Compare
Signed-off-by: jooho <[email protected]>
7ef31f5 to
90fba39
Compare
2c07836 to
912f91c
Compare
Author
|
/retest |
1 similar comment
Author
|
/retest |
dd647ce to
5fd5054
Compare
Signed-off-by: jooho <[email protected]>
5fd5054 to
529b51f
Compare
Xaenalt
approved these changes
May 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, Xaenalt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opendatahub manifests structure is different from upstream manifests. For this reason, it was difficult to synchronize upstream sources to ODH repos. Moreover, fvt test was not working with opendatahub manifests.
The change will help
Modifications
It includes
How to test?
Refer ./opendatahub/docs/manifests-management.md
This doc explains how to deploy and how to test.
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags
==> This is odh-manifest changes so it does not impact these tests.
Issue: