-
Notifications
You must be signed in to change notification settings - Fork 42
Stop odh model controller from adding/removing namespace labels #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop odh model controller from adding/removing namespace labels #34
Conversation
quickstart/quickstart.sh
Outdated
| oc apply -f ../manifests/kfdef.yaml -n $MODELMESH_PROJECT | ||
|
|
||
| oc new-project $INFERENCE_SERVICE_PROJECT | ||
| oc label namespace $INFERENCE_SERVICE_PROJECT "modelmesh-enabled=true" --overwrite=true || echo "INFO: modelmesh-enabled label already exists." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "INFO: modelmesh-enabled label already exists."
That is not the only reason an error could occur (e.g. permission issues), I would use a broader message like "failed to apply label"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :-)
Signed-off-by: Anish Asthana <[email protected]>
|
/lgtm |
|
@HumairAK: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
DaoDaoNoCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tested PR, label does not get applied, and unless you manually apply it, modelmesh will complain: As expected, and once label is manually applied, runtime pods are deployed. |
|
/hold |
|
/unhold |
Test image: quay.io/anishasthana/odh-model-controller-test:v9
Signed-off-by: Anish Asthana [email protected]