Skip to content

Conversation

@anishasthana
Copy link
Member

Test image: quay.io/anishasthana/odh-model-controller-test:v9

Signed-off-by: Anish Asthana [email protected]

oc apply -f ../manifests/kfdef.yaml -n $MODELMESH_PROJECT

oc new-project $INFERENCE_SERVICE_PROJECT
oc label namespace $INFERENCE_SERVICE_PROJECT "modelmesh-enabled=true" --overwrite=true || echo "INFO: modelmesh-enabled label already exists."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo "INFO: modelmesh-enabled label already exists."

That is not the only reason an error could occur (e.g. permission issues), I would use a broader message like "failed to apply label"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :-)

@HumairAK
Copy link

HumairAK commented Nov 4, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2022

@HumairAK: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link

HumairAK commented Nov 7, 2022

Tested PR, label does not get applied, and unless you manually apply it, modelmesh will complain:

{"level":"info","ts":1667858267.6023016,"logger":"controllers.ServingRuntime","msg":"Runtime is disabled, incompatible with modelmesh, or namespace is not modelmesh-enabled","servingruntime":"mesh-test/ovms-1.x"}

As expected, and once label is manually applied, runtime pods are deployed.

@anishasthana anishasthana changed the title WIP: Stop odh model controller from adding/removing namespace labels Stop odh model controller from adding/removing namespace labels Nov 7, 2022
@anishasthana
Copy link
Member Author

/hold

@anishasthana
Copy link
Member Author

/unhold

@openshift-merge-robot openshift-merge-robot merged commit e6eb0ac into opendatahub-io:main Nov 8, 2022
@anishasthana anishasthana deleted the stop_namespace_edits branch November 8, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants