Skip to content

Conversation

@MelissaFlinn
Copy link

Motivation

Copy edit requested by development

Modifications

Multiple updates to the readme files

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@openshift-ci openshift-ci bot requested review from Xaenalt and israel-hdez May 19, 2023 01:56
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2023

Hi @MelissaFlinn. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MelissaFlinn
Copy link
Author

Needs a review by @Jooho

@MelissaFlinn MelissaFlinn changed the title doc-review-qs copy edit of quick starts for ModelMesh WIP: doc-review-qs copy edit of quick starts for ModelMesh May 19, 2023
@MelissaFlinn MelissaFlinn marked this pull request as draft May 19, 2023 02:18
@MelissaFlinn
Copy link
Author

My apologies - this PR needs a review by Jooho Lee before it is merged and so I changed the status to DRAFT

@Jooho
Copy link

Jooho commented May 23, 2023

@MelissaFlinn Thanks for your review!! I leave some comments on the files. Please take a look at them.
Plus, could you add your signature to the commit. This is how you can do

oc commit -s -m "XXX"

@MelissaFlinn MelissaFlinn changed the title WIP: doc-review-qs copy edit of quick starts for ModelMesh doc-review-qs copy edit of quick starts for ModelMesh May 24, 2023
@MelissaFlinn MelissaFlinn marked this pull request as ready for review May 24, 2023 12:25
@MelissaFlinn
Copy link
Author

Thank you @Jooho - I addressed your comments and added my signature to the second commit.
This PR is ready for merging after approval by the project owners. Thank you

Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, MelissaFlinn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f09a618 into opendatahub-io:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants