-
Notifications
You must be signed in to change notification settings - Fork 42
doc-review-qs copy edit of quick starts for ModelMesh #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc-review-qs copy edit of quick starts for ModelMesh #100
Conversation
|
Hi @MelissaFlinn. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Needs a review by @Jooho |
|
My apologies - this PR needs a review by Jooho Lee before it is merged and so I changed the status to DRAFT |
|
@MelissaFlinn Thanks for your review!! I leave some comments on the files. Please take a look at them. |
Signed-off-by: MelissaFlinn <[email protected]>
dbadc6a to
5e8b40e
Compare
|
Thank you @Jooho - I addressed your comments and added my signature to the second commit. |
Jooho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, MelissaFlinn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
Copy edit requested by development
Modifications
Multiple updates to the readme files
Result
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags