Skip to content

Conversation

@AkihiroSuda
Copy link
Member

Lima (http://lima-vm.io) is used to create VM of these distros.

Close #220

kolyshkin
kolyshkin previously approved these changes Mar 3, 2025
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@kolyshkin
Copy link
Collaborator

@rhatdan @thaJeztah PTAL

mrunalp
mrunalp previously approved these changes Mar 5, 2025
@AkihiroSuda
Copy link
Member Author

Updated PR to use https://github.com/lima-vm/lima-actions

@AkihiroSuda AkihiroSuda force-pushed the vm branch 2 times, most recently from bef3072 to 8875323 Compare March 6, 2025 07:32
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions re: caching.

@AkihiroSuda
Copy link
Member Author

Flaky test on Fedora

=== RUN   TestKeyLabel
    label_linux_test.go:202: write /proc/self/attr/keycreate: permission denied
--- FAIL: TestKeyLabel (0.00s)

Lima (http://lima-vm.io) is used to create VM of these distros.

Close issue 220

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin
Copy link
Collaborator

Flaky test on Fedora

=== RUN   TestKeyLabel
    label_linux_test.go:202: write /proc/self/attr/keycreate: permission denied
--- FAIL: TestKeyLabel (0.00s)

I've seen this a few times locally and could not understand why. Maybe @rhatdan knows something? Should we add a retry to the code?

Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@kolyshkin kolyshkin merged commit 6de9828 into opencontainers:main Mar 7, 2025
13 checks passed
@rhatdan
Copy link
Collaborator

rhatdan commented Mar 9, 2025

Permission denied is either SELinux or DAC. Would need to see AVC messages to determine which.

@kolyshkin kolyshkin added this to the v1.12 milestone Mar 12, 2025
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner-as-gitea-act-runner-fork that referenced this pull request Aug 3, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) | `v1.11.0` -> `v1.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopencontainers%2fselinux/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopencontainers%2fselinux/v1.11.0/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>opencontainers/selinux (github.com/opencontainers/selinux)</summary>

### [`v1.12.0`](https://github.com/opencontainers/selinux/releases/tag/v1.12.0)

[Compare Source](opencontainers/selinux@v1.11.1...v1.12.0)

This release removes deprecated functions from the `label` package,
and improves documentation and error reporting of `SetCreateKey`.

#### What's Changed

- VERSION: remove by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#217
- CI: add AlmaLinux 8, CentOS Stream 9, and Fedora by [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda) in opencontainers/selinux#221
- ci: install git-core by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#224
- CI: add openSUSE Tumbleweed by [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda) in opencontainers/selinux#223
- Bump Go version, deps, fix some linter issues... by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#218
- label: remove deprecated stuff by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#228
- Improve SetKeyCreate error reporting, fix test flakes by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#227

**Full Changelog**: opencontainers/selinux@v1.11.1...v1.12.0

### [`v1.11.1`](https://github.com/opencontainers/selinux/releases/tag/v1.11.1)

[Compare Source](opencontainers/selinux@v1.11.0...v1.11.1)

#### What's Changed

- Bump to v1.11.0 by [@&#8203;rhatdan](https://github.com/rhatdan) in opencontainers/selinux#197
- fix some error by [@&#8203;ningmingxiao](https://github.com/ningmingxiao) in opencontainers/selinux#200
- ci: update Go 1.21 support by [@&#8203;michalbiesek](https://github.com/michalbiesek) in opencontainers/selinux#202
- Extend `build-cross` target with `riscv64` arch by [@&#8203;michalbiesek](https://github.com/michalbiesek) in opencontainers/selinux#201
- Remove nolint annotations for unix errno comparisons by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#203
- ci: bump some actions by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#205
- Misc nitpicks by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#206
- pwalk, pwalkdir: fix walk vs remove race by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#204
- Update GitHub Actions CI Go matrix for Go v1.22 by [@&#8203;austinvazquez](https://github.com/austinvazquez) in opencontainers/selinux#209
- Update GitHub Actions packages to resolve deprecation warnings. by [@&#8203;austinvazquez](https://github.com/austinvazquez) in opencontainers/selinux#208
- Add dependabot config by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#210
- build(deps): bump tim-actions/get-pr-commits from 1.3.0 to 1.3.1 by [@&#8203;dependabot](https://github.com/dependabot) in opencontainers/selinux#211
- build(deps): bump golangci/golangci-lint-action from 4 to 6 by [@&#8203;dependabot](https://github.com/dependabot) in opencontainers/selinux#213
- Show SELinux label on failure by [@&#8203;rhatdan](https://github.com/rhatdan) in opencontainers/selinux#216

#### New Contributors

- [@&#8203;ningmingxiao](https://github.com/ningmingxiao) made their first contribution in opencontainers/selinux#200
- [@&#8203;michalbiesek](https://github.com/michalbiesek) made their first contribution in opencontainers/selinux#202
- [@&#8203;dependabot](https://github.com/dependabot) made their first contribution in opencontainers/selinux#211

**Full Changelog**: opencontainers/selinux@v1.11.0...v1.11.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40My41IiwidXBkYXRlZEluVmVyIjoiNDEuNDMuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/801
Reviewed-by: earl-warren <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Cirrus CI to test on Fedora

5 participants