Skip to content

Misc nitpicks #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Misc nitpicks #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6c4501
Makefile: use $(GO) for test
kolyshkin Aug 29, 2023
7f5f17e
Add a TODO to remove min/max
kolyshkin Aug 29, 2023
b8db720
ci: add codespell
kolyshkin Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .codespellrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[codespell]
skip = ./.git,./go.sum,./go-selinux/testdata
10 changes: 10 additions & 0 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ jobs:
with:
version: v1.54

codespell:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- name: install deps
# Version of codespell bundled with Ubuntu is way old, so use pip.
run: pip install codespell
- name: run codespell
run: codespell

Comment on lines +42 to +51
Copy link
Member

@thaJeztah thaJeztah Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I wanted to check if there was an action for this; and then I stumbled on a PR that was adding it; so: yes, there's an action for this; https://github.com/codespell-project/actions-codespell so we may as well use that?

cross:
runs-on: ubuntu-20.04
steps:
Expand Down
2 changes: 1 addition & 1 deletion pkg/pwalkdir/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ filepath.WalkDir.
Otherwise (if a WalkDirFunc is actually doing something) this is usually
faster, except when the WalkDirN(..., 1) is used. Run `go test -bench .`
to see how different operations can benefit from it, as well as how the
level of paralellism affects the speed.
level of parallelism affects the speed.