validation: add env validation for hooks #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate.go
Outdated
| } | ||
|
|
||
| func checkEventHookPaths(hookType string, hooks []rspec.Hook, hooksCheck bool) { | ||
| func hookValid(hookType string, hooks []rspec.Hook, hooksCheck bool) { |
Author
There was a problem hiding this comment.
I think checkEventHooks is OK.
Contributor
|
Two minor nits (I left inline comments), but otherwise 62ab8b7 looks
reasonable to me.
|
Mashimiao
force-pushed
the
add-env-valid-for-hooks
branch
2 times, most recently
from
ba9aa89 to
d558e08
Compare
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
add-env-valid-for-hooks
branch
from
d558e08 to
dd7c579
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]