generate: Change --mount-cgroups default to 'no' #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a937f7a (Add support for using a base template, 2016-04-13, --mount-cgroups is not 'no', that will lead to additional cgroup entries in the mount array (even if there was already a cgroup entry in the mount array). Instead of writing logic to find and clobber existing cgroup entries, just make the default the no-op setting. Signed-off-by: W. Trevor King <[email protected]>
Contributor
Author
|
Looks like my commit message is missing a line. Will fix once I get back to a keyboard. |
Contributor
|
LGTM |
Contributor
Author
Contributor
Author
|
Ah, too late ;). Oh, well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a937f7a (Add support for using a base template, 2016-04-13,
#35), users have been able to supply their own templates. If
--mount-cgroupsis notno, that will lead to additional cgroupentries in the mount array (even if there was already a cgroup entry
in the mount array). Instead of writing logic to find and clobber
existing cgroup entries, just make the default the no-op setting.