Skip to content

Conversation

@zhouhao3
Copy link

It has changed in opencontainers/runtime-spec#783.
Signed-off-by: zhouhao [email protected]

@Mashimiao
Copy link

I think we should keep it.
Spec doesn't contain kernel limit, because in case of kernel limit changes, spec has to change. That's not spec wants.
But in fact, when run containers on Linux, we should follow it's limit. So, I think we should keep this limit for users to generate their container configuration.


**--linux-mem-swappiness**=MEMSWAPPINESS
Sets the swappiness of how the kernel will swap memory pages (Range from 0 to 100).
Sets the swappiness of how the kernel will swap memory pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This limit is still in the spec. I'd argued for keeping it out of the spec, but did not succeed. So I think we want to close this PR and keep the parenthetical you're removing.

@zhouhao3 zhouhao3 closed this Jul 18, 2017
@zhouhao3 zhouhao3 deleted the generate-fix branch July 18, 2017 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants