Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Jul 11, 2017

Which was missed in #371.

Also fix:

wking added 3 commits July 11, 2017 15:28
Adjusting some --bind instances that were missed in 9c3863b
(generate: rectify the arguments, 2017-04-24, opencontainers#371).

Signed-off-by: W. Trevor King <[email protected]>
Adjusting a --cwd instance that was missed in 9c3863b (generate:
rectify the arguments, 2017-04-24, opencontainers#371).

Signed-off-by: W. Trevor King <[email protected]>
Adjusting a --rootfs instance that was missed in d0d4f2d (generate:
update rootfs releated options, 2016-10-21, opencontainers#254).

Signed-off-by: W. Trevor King <[email protected]>
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp
Copy link
Contributor

mrunalp commented Jul 11, 2017

LGTM

Approved with PullApprove

1 similar comment
@Mashimiao
Copy link

Mashimiao commented Jul 12, 2017

LGTM

Approved with PullApprove

@Mashimiao Mashimiao merged commit 8dfbccc into opencontainers:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants