add bundle validate, using reflect to check omitempty

[liangchenye]

Signed-off-by: Liang Chenye [email protected]

Based on previous PR (mrunalp/ocitools#10).

1. correct rootfs reading problem
   way to try it:
   make a bundle 'testbundle for example' by ocitools generate & tar xzvf rootfs.tar.gz
   ocitools bvalidate --path=testbundle
2. add 'reflect' to check 'omitempty' in spec/*go file
   open it once spec version in Godeps updated with opencontainer/specs

[mrunalp]

s/support/supported/

[liangchenye]

Replace original validate.go with new one (bvalidate.go).

@mrunalp @zenlinTechnofreak
so runtimevalidate will not be a sub-command but a test framework, right?

[zenlint]

@liangchenye @mrunalp I think if we named bundle validation tool as validateCommand of ocitool, the only way to push runtime validation tool into the repo is to create a seperate main programme from ocitool, no matter it is a framework or not.

If in that way, I should rebase my PR 'Add initial version of runtimetest command: #9' to a seperate tool, but not a sub command.

What is your design in the ocitools repo? It should be nice if you can let me know. Thanks very much.

[liangchenye]

@zenlinTechnofreak my opinion is we should provides three official sub-command in ocitools.

1. generate
   -- generate bundle according to user's input
2. bundle validate
   -- validate if a bundle is valid
   once the 'layered' bundle released, more validating codes will needed.
3. runtime validate
   -- validate if a runtime is valid
   pass all the test cases you provided.
   it is very similar to test_runtime.sh, the original requirement is Convert test_runtime.sh into a go program mrunalp/ocitools#8

Other command/program/script like get-stage3.sh is important, but maybe suitable to put into a 'contrib' directory. @wking

[wking]

On Tue, Jan 26, 2016 at 02:23:16AM -0800, 梁辰晔 (Liang Chenye) wrote:

Other command/program/script like get-stage3.sh is important, but
maybe suitable to put into a 'contrib' directory. @wking

get-stage3.sh is certainly internal tooling and not part of this
package's public interface. Feel free to put it wherever you like ;).

[mrunalp]

@liangchenye Yes, having these 3 commands makes sense.

[ChengTiesheng]

@liangchenye @zenlinTechnofreak @mrunalp @wking, a more command maybe needed: oci convert, which converts oci bundle to other container images(e.g. docker image or ACI image), any thoughts?

[wking]

On Tue, Jan 26, 2016 at 05:53:44PM -0800, Tiesheng wrote:

oci convert, which converts oci bundle to other container
images(e.g. docker image or ACI image), any thoughts?

Conversions like that are going to be complicated and lossy (at least
in one direction, it seems unlikely that the feature sets are
identical for two tools). I'd rather keep conversion tools like that
in different repositories to cut down on noise in the
conformance-testing tool. But I agree that those tools will be
useful, so +1 to putting them under opencontainers/ if you can attract
enough OCI-member support for them.

[liangchenye]

@ChengTiesheng I'll create a new PR to add 'contrib' directory.
The convert tools could be add to that directory.

[liangchenye]

Use bundleValidateCommand (bvalidate) as the sub-command.

@zenlinTechnofreak maybe you can use
runtimeValidateCommand(rvalidate) as another sub-command to do the runtime test.