validate: modify the valid value of rootfsPropagation #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
commented
Apr 20, 2017
| case "private": | ||
| case "rprivate": | ||
| case "slave": | ||
| case "rslave": |
Author
There was a problem hiding this comment.
On the , rprivate ,rslave, rshared these values, I am not sure whether to delete, because these values are not in the spec.
Contributor
There was a problem hiding this comment.
I'd rather have them added to the spec.
Author
There was a problem hiding this comment.
I think I understand your idea, I will do in the spec.
Signed-off-by: zhouhao <[email protected]>
zhouhao3
force-pushed
the
rootfsPropagation-test
branch
from
8b8fb1a to
1a159f1
Compare
Author
|
Since opencontainers/runtime-spec#770 has been merged，so here also need to change. |
Member
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the shared subtree.
Signed-off-by: zhouhao [email protected]