Revert "Add runtime-validate command" #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da62d5b. The installable approach to runtime validation has been obsoleted by the 'go test ...' approach from 24ca87f (Add tests for runtime validation, 2017-03-06, opencontainers#336). This commit drops the installable tests so we don't have to maintain both. Signed-off-by: W. Trevor King <[email protected]>
Now that that is the only remaining runtime-validation approach. I
ran the tests with runC 1.0.0-rc2, because using 1.0.0-rc3 raised:
$ sudo make RUNTIME=~wking/bin/runc-1.0.0-rc3 localvalidation
RUNTIME=/home/wking/bin/runc-1.0.0-rc3 go test -tags "" -v github.com/opencontainers/runtime-tools/validation
=== RUN TestValidateBasic
json: cannot unmarshal array into Go value of type specs.LinuxCapabilities
--- FAIL: TestValidateBasic (0.03s)
validation_test.go:87: /home/wking/bin/runc-1.0.0-rc3 failed validation: exit status 1
=== RUN TestValidateSysctls
json: cannot unmarshal array into Go value of type specs.LinuxCapabilities
--- FAIL: TestValidateSysctls (0.03s)
validation_test.go:96: /home/wking/bin/runc-1.0.0-rc3 failed validation: exit status 1
FAIL
exit status 1
FAIL github.com/opencontainers/runtime-tools/validation 0.055s
make: *** [Makefile:40: localvalidation] Error 1
because runtime-tools hasn't adjusted to the new seccomp config yet.
Signed-off-by: W. Trevor King <[email protected]>
Contributor
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit da62d5b (#326).
The installable approach to runtime validation has been obsoleted by the
go test …approach from #336. This pull-request drops the installable tests so we don't have to maintain both. Also obsoletes #352.