generate: fix removing namespace bug #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are duplicated namespace items, we should remove all of them. Signed-off-by: Ma Shimiao <[email protected]>
Contributor
|
On Tue, Dec 20, 2016 at 07:55:21PM -0800, Ma Shimiao wrote:
When there are duplicated namespace items, we should remove all of
them.
This is not a legal state (opencontainers/runtime-spec#597). I think
a more robust approach is to fix the erroneous code that produces such
entries (which may be living outside this repository). To protect
against buggy templates, I'm fine supporting a
--linux--namespace-dedup option (or some such), but I don't think we
want to tie it to RemoveLinuxNamespace.
|
Author
|
Currently, prefer to give users warning by #390 to guarantee valid template. If we have valid template, this fix will not needed any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are duplicated namespace items, we should remove all of them.
Signed-off-by: Ma Shimiao [email protected]