validate: add hard and soft limit check for rlimit #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
validate-add-hard-soft-limit-check
branch
from
95aeec0 to
f175fae
Compare
wking
reviewed
Sep 27, 2016
| msgs = append(msgs, fmt.Sprintf("rlimit type %q is invalid.", process.Rlimits[index].Type)) | ||
| } | ||
| if process.Rlimits[index].Hard < process.Rlimits[index].Soft { | ||
| msgs = append(msgs, fmt.Sprintf("hard limit of rlimit %s should not be less than soft limit.", process.Rlimits[index].Type)) |
Contributor
There was a problem hiding this comment.
f175fae looks fine to me vs. the current spec.
I'd rather not refer to array entries by a property of their value (resource Type). I've filed opencontainers/runtime-spec#583, and if/when that lands referencing a particular entry by the resource will be more justified. If the runtime-spec PR is rejected, I can file a follow-up PR here so we report errors by index. Either way, I'm fine with this PR landing as it stands now, since checking with some ambiguity around the error message is better than no checking at all ;).
Contributor
|
LGTM |
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 13, 2016
Signed-off-by: Ma Shimiao <[email protected]> Backported to v1.0.0.rc1 from f175fae opencontainers#223 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <[email protected]>
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 15, 2016
Signed-off-by: Ma Shimiao <[email protected]> Backported to v1.0.0.rc1 from f175fae opencontainers#223 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]