Skip to content

generate: add pids limit support #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrunalp merged 1 commit into from
Oct 11, 2016
Merged

generate: add pids limit support #206

mrunalp merged 1 commit into from
Oct 11, 2016

Conversation

@Mashimiao
Copy link

@Mashimiao Mashimiao commented Sep 9, 2016

Signed-off-by: Ma Shimiao [email protected]

@wking
Copy link
Contributor

wking commented Sep 14, 2016

62a25b9 looks fine to me.

I'd like to get a plan for clearing these values before we go too much
farther down this path, though 1. It would be a shame to put in
lots of work and then have to translate to a different pattern to
support clearing. My preferred pattern is to use our own StringFlag →
*int64 (etc.) helpers 2.

 And most of the rest of that PR's discussion.

@Mashimiao Mashimiao force-pushed the generate-add-pids-limit-support branch from 62a25b9 to beb6478 Compare September 22, 2016 02:26
@Mashimiao
Copy link
Author

Mashimiao commented Sep 22, 2016

PR rebased.
Ping @mrunalp @liangchenye

@mrunalp
Copy link
Contributor

mrunalp commented Oct 11, 2016

LGTM

@mrunalp mrunalp merged commit 1709409 into opencontainers:master Oct 11, 2016
wking pushed a commit to wking/ocitools-v2 that referenced this pull request Oct 13, 2016
@wking
generate: add pids limit support
ad168d9 
Signed-off-by: Ma Shimiao <[email protected]>

Backported to v1.0.0.rc1 from beb6478 opencontainers#206 (cherry-pick applied
cleanly).

Signed-off-by: W. Trevor King <[email protected]>
@wking wking mentioned this pull request Oct 13, 2016
Merged
wking pushed a commit to wking/ocitools-v2 that referenced this pull request Oct 15, 2016
@wking
generate: add pids limit support
57c656c 
Signed-off-by: Ma Shimiao <[email protected]>

Backported to v1.0.0.rc1 from beb6478 opencontainers#206 (cherry-pick applied
cleanly).

Signed-off-by: W. Trevor King <[email protected]>
@Mashimiao Mashimiao deleted the generate-add-pids-limit-support branch November 14, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mashimiao @wking @mrunalp