man: fix description for rootfs #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
man-fix-des-for-rootfs
branch
from
130d8e9 to
315f37d
Compare
man/ocitools-generate.1.md
Outdated
| Path to the rootfs | ||
| Path to the rootfs, which is relative to bundle path. | ||
| e.g the absolute path of rootfs is /to/bundle/rootfs, bundle path is /to/bundle, | ||
| then the value set as ROOTFSPATH should be `rootfs`. |
Contributor
There was a problem hiding this comment.
This is useful information, but I think we want to land it in runtime-spec first. Currently runtime-spec is fairly weak on how relative paths should be handled, although relative path semantics for cgroupsPath have become more clear recently.
Mashimiao
force-pushed
the
man-fix-des-for-rootfs
branch
from
315f37d to
c909488
Compare
Author
|
PR rebased. |
Member
|
@Mashimiao |
Member
|
Relevant PR |
Author
|
If need to change as spec, we have to wait #233 to be merged. It matches the current implementation. |
Mashimiao
force-pushed
the
man-fix-des-for-rootfs
branch
from
c909488 to
aa87e86
Compare
Author
|
@liangchenye @mrunalp fixed and rebased. |
Contributor
|
aa87e86 looks good to me. It skirts the current bundle requirement
that I'm trying to lift with the in-flight
opencontainers/runtime-spec#469, but we can tighten down on that in a
subsequent PR.
|
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
man-fix-des-for-rootfs
branch
from
aa87e86 to
a325e66
Compare
Author
|
rebased. @opencontainers/runtime-tools-maintainers PTAL |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]