Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Aug 16, 2016

Signed-off-by: Ma Shimiao [email protected]

Backported to v1.0.0.rc1 from 5de50e5 #189 (cherry-pick applied
cleanly).

Signed-off-by: W. Trevor King [email protected]

Signed-off-by: Ma Shimiao <[email protected]>

Backported to v1.0.0.rc1 from 5de50e5 opencontainers#189 (cherry-pick applied
cleanly).

Signed-off-by: W. Trevor King <[email protected]>
@mrunalp
Copy link
Contributor

mrunalp commented Sep 1, 2016

LGTM

@mrunalp mrunalp merged commit 3091c7e into opencontainers:v1.0.0.rc1 Sep 1, 2016
wking added a commit to wking/ocitools-v2 that referenced this pull request Sep 1, 2016
* v1.0.0.rc1:
  man/ocitools.1: Replace "**...(1)**" with "**...**(1)"
  add namespace check for uid/gid mappings
  validation: add linux resource check
  add label manpage and fix help
  support setting oom_score_adj
  generate: fix mount-cgroups bug
  completions: update based on generate help message
  update urfave/cli package to v1.18.0
  generate: optimize namespace setup log and fix manpage
  change param type of AddProcessAdditionalGid
  remove unnecessary return error value
  Modify generate API
  Add Travis CI badge to README
  generate: fix capability.List() for cap_last_cap not exist
  generate: remove unnecessary spec initialization
  generate: fix tmpfs adding based on manpage
  Check CAP_LAST_CAP while setting privileged
  generate: Remove superfluous err check from Save

Signed-off-by: W. Trevor King <[email protected]>

Conflicts:
	cmd/ocitools/generate.go
	man/ocitools-generate.1.md

The conflicts are because:

* support setting oom_score_adj (opencontainers#176, opencontainers#185)
* add label manpage and fix help (opencontainers#189, opencontainers#190)

have landed in master and been backported to v1.0.0.rc1 since this
branch split from master.  They wouldn't have happend if I'd rebased
this branch on the current master before merging v1.0.0.rc1, but then
I'd have to repeat the initial dance done with eac0762 (Merge commit
'30e2ea2', 2016-08-02) and b45bebd (Merge commit '6acca9e',
2016-08-02).
@wking wking deleted the man-add-label-and-fix-help branch September 23, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants