generate: optimize namespace setup log and fix manpage #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
man/ocitools-generate.1.md
Outdated
| Use a Cgroup namespace. *PATH* to file of an existing Cgroup namespace. | ||
| If *PATH* is set, join that namespace. The sepcial *PATH* "" set to | ||
| create a new namespace. The special *PATH* `host` removes any existing | ||
| Cgroup namespace from the configuration. |
Contributor
There was a problem hiding this comment.
There's a “sepcial” → “special” typo in here. And the first two sentences read a bit awkardly to me. How about:
Use a Cgroup namespace where PATH is an existing Cgroup namespace file to join. The special empty-string PATH creates a new namespace. The special PATH
hostremoves any existing Cgroup namespace from the configuration.
Author
There was a problem hiding this comment.
On 08/02/2016 12:39 AM, W. Trevor King wrote:
There's a “sepcial” → “special” typo in here. And the first two sentences read a bit awkardly to me. How about:
Use a Cgroup namespace where /PATH/ is an existing Cgroup namespace file to join. The special empty-string /PATH/ creates a new namespace. The special /PATH/ |host| removes any existing Cgroup namespace from the configuration.
Thx, fixed.
Mashimiao
force-pushed
the
generate-namespace-optimize-fix-manpage
branch
from
f4759ca to
33f49a2
Compare
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
generate-namespace-optimize-fix-manpage
branch
from
33f49a2 to
15f529b
Compare
Contributor
|
15f529b looks good to me.
|
Contributor
|
LGTM |
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Aug 3, 2016
Signed-off-by: Ma Shimiao <[email protected]> Backported to v1.0.0.rc1 from 15f529b opencontainers#166 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]