-
Notifications
You must be signed in to change notification settings - Fork 159
generate: Remove superfluous err check from Save #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: W. Trevor King <[email protected]>
|
The fix seems good. But why just fix v1.0.0.rc1 not master? |
|
On Wed, Jul 27, 2016 at 10:46:20PM -0700, Ma Shimiao wrote:
So we can just merge v1.0.0.rc1 into master periodically to pull |
|
Got it. I just think it's a little wired. In my opinion, master should be the newest branch. |
|
On Wed, Jul 27, 2016 at 11:07:42PM -0700, Ma Shimiao wrote:
Master is the newest branch. I just think new commits should target |
|
@wking While that approach sounds good for kernel development, I think that the github model that most developers are used to is submitting PRs to master and backporting to other stable branches. |
|
On Thu, Jul 28, 2016 at 04:05:58PM -0700, Mrunal Patel wrote:
It depends on who submits/reviews the v1.0.0.rc1 PRs. I think there |
|
LGTM. But we'll need to get this into master later. |
|
On Tue, Aug 02, 2016 at 05:06:13PM -0700, Mrunal Patel wrote:
I'm setting up a merge from v1.0.0.rc1, but we'll need to catch |
Same as #160, but targeting v1.0.0.rc1.