Skip to content

validate: add sysctl check #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrunalp merged 1 commit into from
Jul 7, 2016
Merged

validate: add sysctl check #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ func checkProcess(process rspec.Process, rootfs string) {
//Linux only
func checkLinux(spec rspec.Spec) {
utsExists := false
ipcExists := false
mountExists := false
netExists := false

if len(spec.Linux.UIDMappings) > 5 {
logrus.Fatalf("Only 5 UID mappings are allowed (linux kernel restriction).")
Expand All @@ -206,8 +209,27 @@ func checkLinux(spec rspec.Spec) {
for index := 0; index < len(spec.Linux.Namespaces); index++ {
if !namespaceValid(spec.Linux.Namespaces[index]) {
logrus.Fatalf("namespace %v is invalid.", spec.Linux.Namespaces[index])
} else if spec.Linux.Namespaces[index].Type == rspec.UTSNamespace {
utsExists = true
} else if len(spec.Linux.Namespaces[index].Path) == 0 {
if spec.Linux.Namespaces[index].Type == rspec.UTSNamespace {
utsExists = true
} else if spec.Linux.Namespaces[index].Type == rspec.IPCNamespace {
ipcExists = true
} else if spec.Linux.Namespaces[index].Type == rspec.NetworkNamespace {
netExists = true
} else if spec.Linux.Namespaces[index].Type == rspec.MountNamespace {
mountExists = true
}
}
}

for k := range spec.Linux.Sysctl {
if strings.HasPrefix(k, "net.") && !netExists {
logrus.Fatalf("Sysctl %v requires a new Network namespace to be specified as well", k)
}
if strings.HasPrefix(k, "fs.mqueue.") {
if !mountExists || !ipcExists {
logrus.Fatalf("Sysctl %v requires a new IPC namespace and Mount namespace to be specified as well", k)
}
}
}

Expand Down