Remove redundancy in config.go #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <[email protected]>
wking
approved these changes
May 24, 2017
mrunalp
approved these changes
May 25, 2017
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Being a
neat freakwhile going through final reviews of the spec. There were some redundant inconsistent comments in some of the Linux structures. This PR makesconfig.goconsistent across all platforms in terms of the style of comment. In addition, there is no need to mention "Hyper-V containers" explicitly at the top level. And corrected the "platform" based containers comment in the top levelSpecstructure.