Skip to content

Conversation

@Mashimiao
Copy link

I think this make clear what reference the directory in config.json

Signed-off-by: Ma Shimiao [email protected]

bundle.md Outdated
2. <a name="containerFormat02" />A directory representing the root filesystem of the container.
While the name of this REQUIRED directory may be arbitrary, users should consider using a conventional name, such as `rootfs`.
This directory MUST be referenced from within the `config.json` file.
This directory MUST be referenced by [root](config.md#root) within the `config.json` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want backticks around root to match our existing pattern.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated

I think this make clear what reference the directory in config.json

Signed-off-by: Ma Shimiao <[email protected]>
@Mashimiao Mashimiao force-pushed the bundle-root-reference branch from 3dd4fc6 to 5a90133 Compare May 11, 2017 01:28
@crosbymichael
Copy link
Member

crosbymichael commented May 11, 2017

LGTM

Approved with PullApprove

@tianon
Copy link
Member

tianon commented May 11, 2017

LGTM

Approved with PullApprove

@tianon tianon merged commit 1259a08 into opencontainers:master May 11, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants